[CinCV TNG] [PATCH] New base class Selection

Einar Rünkaru einarrunkaru at gmail.com
Wed Aug 30 18:03:43 CEST 2017



On 08/29/2017 12:11 AM, Johannes Sixt wrote:
> Am 28.08.2017 um 21:43 schrieb Einar Rünkaru:
>> Hi.
>>
>> Selection is a textbox with popup menu of values
>> The derived classes hold tables of internal values
>> with corresponding strings shown to user.
>> To add or remove a value only the table needs change.
> 
> It is desirable to have such a thing.
> 
> But, oh boy, the name! You are squatting such a generic name, 
> "Selection", for something that is not a "selection". Please make it 
> less generic, such as SelectionTextBox.

Selection may consist of 2 textboxes, popup menu and 2 buttons. It is 
not textbox any more.

For me Selection is an object what is able to convert numerixal 
representation to textual representation. As a bonus it can make a GUI 
and ask the value from user.

I cant see why SelectionTextBox is better than Selection.

And as Selection is ported from CVE, I have no interest to rename 
something in 3 year old program.

Einar


More information about the Cinelerra mailing list