[CinCV TNG] [PATCH] Fix compilation failure due to API change of a52_init().

Einar Rünkaru einarrunkaru at gmail.com
Sun Aug 27 14:33:34 CEST 2017



On 08/26/2017 12:55 PM, Johannes Sixt wrote:
> Recent versions of liba52 removed the required argument from a52_init().
> They should really have defined a new funciton or declared variadic
> arguments (...) if they are ignored anyway. But they didn't. Check the
> API during configuration for compatibility with users who have not yet
> upgraded liba52.
> 
> ---
> 
> I have a system with a recent liba52 and cannot test the case where 
> a52_init still needs an argument. Tests appreciated.
> 

I have the case where a52_init needs an argument.

Output of ./configure
checking for a52_init in -la52... yes
checking a52dec/a52.h usability... yes
checking a52dec/a52.h presence... yes
checking for a52dec/a52.h... yes
checking whether a52_init requires an argument... yes

config.h:
* config.h.  Generated from config.h.in by configure.  */
/* config.h.in.  Generated from configure.ac by autoheader.  */

/* Define to 1 if an argument must be passed to a52_init. */
/* #undef A52_INIT_NEEDS_ARG */

Result of compilation:
ac3.c: In function ‘mpeg3_new_ac3’:
ac3.c:19:18: error: too few arguments to function ‘a52_init’
   result->state = a52_init();
                   ^
In file included from ac3.c:5:0:
/usr/include/a52dec/a52.h:134:15: note: declared here
  a52_state_t * a52_init (uint32_t mm_accel);
                ^
---

Please fix and resend.

Einar


More information about the Cinelerra mailing list