[CinCV TNG] [PATCH] Make aspect_h and aspect_w doubles in EDLSession

Johannes Sixt j6t at kdbg.org
Sat Aug 26 11:03:55 CEST 2017


Am 24.08.2017 um 22:47 schrieb Einar R√ľnkaru:
> Hi.
> 
> There is no point to use float single variables on
> modern computers. They are often converted silently
> to doubles and back and they loose quickly accuracy
> during uncareful computation sequences.
> Change the types step by step as needed in the future.

I do not buy the argument about accuracy. Can you present an example 
where there is unwanted round-off? I simply do not see where aspect_w 
and aspect_h are involved in calculations. (There is one in shapewipe, 
but it is

Also, it is not true that computers convert to double internally. I have 
looked at sufficient assembly generated by gcc recently that I know that 
all operations involving type float are perfermed with SSE single 
precision instructions.

Furthermore, the patch is incomplete. There is float aspect_w in 
pluginvclient.h and assignments from atof() in new.C.

Please do not apply this patch until there is evidence that it is needed.

Thanks,
-- Hannes


More information about the Cinelerra mailing list