[CinCV TNG] [PATCH] Use functions of BC_CModels for colorspace operations in cinelerra

Einar Rünkaru einarrunkaru at gmail.com
Thu Aug 10 19:53:09 CEST 2017


Hi.

On 08/09/2017 11:39 AM, Einar Rünkaru wrote:
> 
> 
> On 9 August 2017 at 00:17, Johannes Sixt <j6t at kdbg.org 
> <mailto:j6t at kdbg.org>> wrote:
> 
>     -                       cmodel_transfer(frame->get_rows(),
> 
>         -                               temp_frame->get_rows(),
>         -                               frame->get_y(),
>         -                               frame->get_u(),
>         -                               frame->get_v(),
>         -                               temp_frame->get_y(),
>         -                               temp_frame->get_u(),
>         -                               temp_frame->get_v(),
>         -                               0,
>         -                               0,
>         -                               temp_frame->get_w(),
>         -                               temp_frame->get_h(),
>         -                               0,
>         -                               0,
>         -                               frame->get_w(),
>         -                               frame->get_h(),
>         -                               temp_frame->get_color_model(),
>         -                               frame->get_color_model(),
>         -                               0,
>         -                               temp_frame->get_w(),
>         -                               frame->get_w());
>         +                       frame->transfer_from(temp_frame);
> 
> 
>     The last two arguments in the old code are get_w(), the frame width.
>     But in the new code it is get_bytes_per_line() as part of
>     transfer_from(). Why is this OK?
> 
> 
> The current implementation ignores the last two arguments. So what 
> anybody wrote there is unimportant. Probably the idea was bytes per 
> line. The new implementation (not ready yet) will require 
> bytes_per_line.  I have intention to get rid of the row pointers.
> 

Patch applied.

Thanks,
Einar


More information about the Cinelerra mailing list