[CinCV TNG] [PATCH] Removed disabled code from Sema
j6t at kdbg.org
Sun Aug 6 23:06:21 CEST 2017
Am 06.08.2017 um 19:26 schrieb Einar Rünkaru:
> On 08/06/2017 12:06 PM, Johannes Sixt wrote:
>> Am 04.08.2017 um 17:52 schrieb Einar Rünkaru:
>>> Patch attached.
>> Since this removes a reference to bcipc.h, this patch should come
>> before the one that removes bcipc.h so that after _that_ patch, there
>> is really no reference of bcipc.h in the code.
> This is disabled code - compiler does not see it. For me it is unrelated
> change and order does not matter.
I certainly understand that. However, after a patch "removed all of
bcipc", it is very distracting when 'git grep bcipc' still shows some
hits. One has to wonder why things are still OK or whether something
went wrong. That is why I suggest to have 'remove everything of foo'
patches last. (Or have them remove *really* everything, even disabled
More information about the Cinelerra