[CinCV TNG] [PATCH] Fixed initialization of colorspace conversions

Johannes Sixt j6t at kdbg.org
Mon Jul 10 18:36:36 CEST 2017


Am 09.07.2017 um 18:26 schrieb Einar R√ľnkaru:
> Hi.
> 
> The constructor of BC_CModels initalizes RGB->YUV conversion
> tables. Making BC_CModels part of BC_Resources ensures the
> initialization of tables before any use.

Before this patch, I cannot find a single line of code where an object 
of type BC_CModels would be allocated nor is there an explicit call of 
init_yuv() outside the BC_CModels constructor. Does it mean that these 
tables were never initialized at all? If so, a sentence about this fact 
would be welcome in the commit message as well as an explanation what 
the consequences were. Are there any bug reports about wrong behavior? 
If not, are these tables unused?

-- Hannes


More information about the Cinelerra mailing list