[CinCV TNG] [PATCH] Cosmetics and cleanup in FileJPEG

Einar Rünkaru einarrunkaru at gmail.com
Sun Jul 9 15:54:38 CEST 2017



On 07/08/2017 04:24 PM, Johannes Sixt wrote:
> Am 07.07.2017 um 18:01 schrieb Einar Rünkaru:
>> Removed empty destructor, empty lines, out commented lines,
>> pointless breaks after return, corrected indetation.
>> Add icon to configuration window.
>> ---
>>   cinelerra/filejpeg.C | 72 
>> ++++++++++++----------------------------------------
>>   cinelerra/filejpeg.h |  2 --
>>   2 files changed, 16 insertions(+), 58 deletions(-)
>>
>> diff --git a/cinelerra/filejpeg.C b/cinelerra/filejpeg.C
>> index dd71518..9633360 100644
>> --- a/cinelerra/filejpeg.C
>> +++ b/cinelerra/filejpeg.C
>> @@ -33,7 +33,9 @@
>>   #include "vframe.h"
>>   #include "videodevice.inc"
>>   #include "mainerror.h"
>> +#include "theme.h"
>> +extern Theme *theme_global;
> 
> Two things:
> 
> - Please keep #include files in alphabetical order, as is customary in 
> this code base.
> 
> - Please do not declare extern theme_global here. A better place is 
> mwindow.h, I would say.
> 
>> -int JPEGConfigVideo::close_event()
>> -{
>> -    set_done(0);
>> -    return 1;
>> -}
>> -
> 
> It is somewhat surprising that you remove this function without 
> explaining why that is possible.
> 

This overides BC_WindowBase which is almost the same with the exeption 
that it calls set_done(1). The parameter is the result returned by 
run_window, but nobody cares about it.

I add the explanation to the description of the commit.

Einar


More information about the Cinelerra mailing list