[CinCV TNG] [PATCH] Cosmetics and cleanup in FileJPEG

Johannes Sixt j6t at kdbg.org
Sat Jul 8 15:24:37 CEST 2017


Am 07.07.2017 um 18:01 schrieb Einar R√ľnkaru:
> Removed empty destructor, empty lines, out commented lines,
> pointless breaks after return, corrected indetation.
> Add icon to configuration window.
> ---
>   cinelerra/filejpeg.C | 72 ++++++++++++----------------------------------------
>   cinelerra/filejpeg.h |  2 --
>   2 files changed, 16 insertions(+), 58 deletions(-)
> 
> diff --git a/cinelerra/filejpeg.C b/cinelerra/filejpeg.C
> index dd71518..9633360 100644
> --- a/cinelerra/filejpeg.C
> +++ b/cinelerra/filejpeg.C
> @@ -33,7 +33,9 @@
>   #include "vframe.h"
>   #include "videodevice.inc"
>   #include "mainerror.h"
> +#include "theme.h"
>   
> +extern Theme *theme_global;

Two things:

- Please keep #include files in alphabetical order, as is customary in 
this code base.

- Please do not declare extern theme_global here. A better place is 
mwindow.h, I would say.

> -int JPEGConfigVideo::close_event()
> -{
> -	set_done(0);
> -	return 1;
> -}
> -

It is somewhat surprising that you remove this function without 
explaining why that is possible.

-- Hannes


More information about the Cinelerra mailing list