[CinCV TNG] [PATCH] Cosmetics and clenup in MainError

Einar Rünkaru einarrunkaru at gmail.com
Fri Jul 7 14:33:36 CEST 2017


Hi.

On 07/07/2017 12:18 AM, Johannes Sixt wrote:
> Am 06.07.2017 um 22:41 schrieb Einar Rünkaru:
>> Removed empty destructor, empty lines, trace macros,
>> corrected indetation.
> 
> Looks good, but...
> 
>>       add_subwindow(list = new BC_ListBox(x,
>> -                y,
>> -                get_w() - 20,
>> -                button->get_y() - y - 5,
>> -                LISTBOX_TEXT,                   // Display text list 
>> or icons
>> -                &thread->errors, // Each column has an ArrayList of 
>> BC_ListBoxItems.
>> -                0,             // Titles for columns.  Set to 0 for 
>> no titles
>> -                0,                // width of each column
>> -                1,                      // Total columns.  Only 1 in 
>> icon mode
>> -                0,                    // Pixel of top of window.
>> -                0,                     // If this listbox is a popup 
>> window with a button
>> -                LISTBOX_SINGLE,  // Select one item or multiple items
>> -                ICON_LEFT,        // Position of icon relative to 
>> text of each item
>> -                0));
>> -SET_TRACE
>> +        y,
>> +        get_w() - 20,
>> +        button->get_y() - y - 5,
>> +        LISTBOX_TEXT,                   // Display text list or icons
>> +        &thread->errors));               // Each column has an 
>> ArrayList of BC_ListBoxItems.
> 
> ... this caught my eye. It seems to be customary everywhere else to 
> specify all arguments up to the last non-default one. So, brings a bit 
> of consistency.
> 
> -- Hannes

Hmm. I removed values which are default. I missed something?

Einar


More information about the Cinelerra mailing list