[CinCV TNG] [PATCH] Draw video while edit is less than picon width

igor_ubuntu sitelve at gmail.com
Sat Nov 26 17:02:29 CET 2016


Draw video while edit is less than picon width
The change is ported from Einar's git.
----------



Some time ago Cinelerra's user WP posed the question `Preview on track and
redrawing`
 quote:
 ".*. seeing "holes" in the preview is very counterintuitive, as it looks
like the video track is split."*
http://lists.cinelerra-cv.org/pipermail/cinelerra/2016q4/005387.html
----------

I mentioned  that this is is typical not only for C5.1, but for all other
branches of
Cinelerra's world.
Only CVE does not have this problem. All preview-frames are redrawn
properly in a track independently of zooming.
Because it has https://git.cinelerra-cv.org/gitweb?p=einar/cinelerra.git;a=
commit;h=7367ac60d2d4e563a515b6a580246b7b16849a42
---------

GG made some changes and implementes some compromiss in his git
https://git.cinelerra-cv.org/gitweb?p=goodguy/cinelerra.git;
a=blobdiff;f=cinelerra-5.1/cinelerra/resourcepixmap.C;h=f
184e2fe17d23f5757aaa88a4ae39b86c6b31e6e;hp=00cf796548eb33a7c
3c91f83b54e652819bd9df6;hb=439d655274ef8385d20db9b75bbff63b4
300ec7b;hpb=0983c78067d86d25426fd34655ad9a9992ef04c7
because http://lists.cinelerra-cv.org/pipermail/cinelerra/2016q4/005396.html
quote:


*..I have had several real sessions where the edit count on the timeline is
quite high, and in these cases eachedit would add an additional seek,
decode, scale, draw.  It could beexpensive for no gain at all if the images
are all just slivers at wide scale.*
---------------

Complexities and pitfalls are that both solutions will sightly slow down
refresh where there are a bunch of short edits.
I want to fix this problem of black holes in CVO but there is a debatable
question  `what is better: 5.1's compromise behavior  or CVE's ?` here.
So a main question is wether user likes timeline with black holes, or a bit
slower timeline without.

I have done a series of crash-tests and can't say that 5.1's limitation has
obvious benefits.
I have the same glitches and hangs during rapid increasing a height of  a
track both with CVE's solution and with C5.1' solution.
I do not see the difference in speed drawing of preview images on a track
during the zoom of track

Therefore I am suggesting this patch with CVE' behavior  for CVO.

However, only big testing can show what is better.
I am inviting cinelerra's users to testing.
Any feedback is welcome and appreciated.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20161126/ab4d3cc2/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Draw-video-while-edit-is-less-than-picon-width.patch
Type: text/x-diff
Size: 915 bytes
Desc: not available
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20161126/ab4d3cc2/attachment.patch>


More information about the Cinelerra mailing list