[CinCV TNG] [PATCH] Removed internal fonts

Sérgio Basto sergio at serjux.com
Mon Oct 26 18:15:08 CET 2015


On Seg, 2015-10-26 at 08:43 +0100, Johannes Sixt wrote:
> Am 26.10.2015 um 04:03 schrieb Sérgio M. Basto:
> > Copied from einar branch.
> 
> Thanks for your efforts to mention the real author of this change. 

Just a note, look at this patch at 2009
http://www.openmamba.org/showfile.html?file=/pub/openmamba/devel/patches/cinelerra-cv-2.1.5-remove-fontts.patch

> However, with git, you can do better. Here's how I would have done it in 
> this case:
> 
>    git cherry-pick 22060fce5973    # the font removal patch
>    git cherry-pick -n 772c7bec1f75 # the configure.ac fixup

Both patches have conflicts , I can't apply directly , I had tried that
before .

>    git commit --amend              # keep 1st patch's commit details
>    git format-patch -D -1 HEAD
> 
> and then use git-send-email to send out the patch or ensure to keep the 
> From:-Line that is in the format-patch file, separated by a blank line 
> above the commit message summary.
> 
> The -D in the format-patch instruction generates an irreversible patch. 
> It basically records only the deletion of files, but does not include 
> the (binary) patch text. Even though the patch would not be applicable 
> as is, it shows which files must be removed.

Thank you for these comprehensive explanations.

> (I would have submitted the patch for real, but my Cinelerra tree is 
> currently unavailable.)

yes,  please apply whatever you think is better  

> > Fonts are old and probably not redistributable
> > Modern distributions have enough scaleable fonts.
> 
> In general, I agree to this change.
> 
> -- Hannes


Thanks,
-- 
Sérgio M. B.



More information about the Cinelerra mailing list