[CinCV TNG] RFC:Next version

igor_ubuntu sitelve at gmail.com
Thu May 21 19:32:37 CEST 2015


. //Any other confirmation?//
I confirm - after Feather >60
But why make this restriction?
The user who encounter with this problem will simple not to use high values.

2015-05-21 20:25 GMT+03:00 Nicola Ferralis <feranick at hotmail.com>:

> Hi,
>
> Yes, you are correct. The different variables have been reshuffled in 4.6.
> What is now a set of parameters in the definition of do_feather, were
> before included within the call itself.
>
> I am in favor of your practical fix. The question is: what's the highest
> value we should set as the limit? Hannes mentioned ~0.6 is where things
> start to break down. Any other confirmation?
>
> Thanks,
> Nicola
>
>
> On 5/21/15 1:19 PM, Einar R√ľnkaru wrote:
>
>> Hi
>>
>> On 05/20/2015 09:29 PM, Johannes Sixt wrote:
>>
>>> Am 20.05.2015 um 19:51 schrieb Nicola Ferralis:
>>>
>>>> Not sure if this is where the problem is... But one notable difference
>>>> between the MaskUnit::do_feather in CV 2.2 (where it seems to be broken)
>>>> and HV 4.6 (where it seems to work) is the casting of feather. In 4.6:
>>>>
>>>> void MaskUnit::do_feather(VFrame *output,
>>>>                            VFrame *input,
>>>>                            double feather,
>>>>                            int start_y,
>>>>                            int end_y,
>>>>                            int start_x,
>>>>                            int end_x)
>>>>
>>>> in CV:
>>>>
>>>> void MaskUnit::do_feather(VFrame *output,
>>>>      VFrame *input,
>>>>      float feather,
>>>>      int start_out,
>>>>      int end_out)
>>>>
>>>> This is percolated through the code with other variables been casted as
>>>> double rather than floats in MaskUnit::do_feather.
>>>>
>>>
>>> It's not impossible. It is barely an overflow as the numbers do not grow
>>> ad infinitum. On the other hand, there are a number additions and
>>> subtractions, and it is possible that numeric imprecision causes the
>>> observed problems.
>>>
>>>
>> I see one more difference: there are 4 parameters after feather in HV vs
>> 2 parameters in CV. I suspect that there are more changes in HV. This
>> means that the real fix is not small and simple.
>>
>> Small and simple fix is to restrict feather to 0..40.
>>
>> My idea is to release next version before we start to merge from HV.
>>
>> Einar
>> _______________________________________________
>> Cinelerra mailing list
>> Cinelerra at lists.cinelerra-cv.org
>> http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra
>>
>
> _______________________________________________
> Cinelerra mailing list
> Cinelerra at lists.cinelerra-cv.org
> http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20150521/3283721e/attachment.html>


More information about the Cinelerra mailing list