[CinCV TNG] RFC:Next version

Nicola Ferralis feranick at hotmail.com
Wed May 20 21:30:32 CEST 2015


OK, Please find attached a *test patch* where I replaced the casting for 
several variables from float to double, to match 4.6. It would be great 
if someone can test it.

Thanks,
Nicola

P.S. If this works, I'll submit it in a separate thread as required.

On 5/20/15 2:29 PM, Johannes Sixt wrote:
> Am 20.05.2015 um 19:51 schrieb Nicola Ferralis:
>> Not sure if this is where the problem is... But one notable difference
>> between the MaskUnit::do_feather in CV 2.2 (where it seems to be broken)
>> and HV 4.6 (where it seems to work) is the casting of feather. In 4.6:
>>
>> void MaskUnit::do_feather(VFrame *output,
>>                            VFrame *input,
>>                            double feather,
>>                            int start_y,
>>                            int end_y,
>>                            int start_x,
>>                            int end_x)
>>
>> in CV:
>>
>> void MaskUnit::do_feather(VFrame *output,
>>      VFrame *input,
>>      float feather,
>>      int start_out,
>>      int end_out)
>>
>> This is percolated through the code with other variables been casted as
>> double rather than floats in MaskUnit::do_feather.
>
> It's not impossible. It is barely an overflow as the numbers do not grow
> ad infinitum. On the other hand, there are a number additions and
> subtractions, and it is possible that numeric imprecision causes the
> observed problems.
>
> -- Hannes
>
> _______________________________________________
> Cinelerra mailing list
> Cinelerra at lists.cinelerra-cv.org
> http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Changing-cast-from-float-to-double-to-fix-do_feather.patch
Type: text/x-diff
Size: 4205 bytes
Desc: not available
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20150520/dbb3a503/attachment.patch>


More information about the Cinelerra mailing list