[CinCV TNG] [PATCH] Add GreyCStoration plugin to Cinelerra-CV

Nicola Ferralis feranick at hotmail.com
Sat May 2 22:53:41 CEST 2015


Updated patch attached:

   - Dropped the 2 in the name of the patch (name is now the same as 
original submission)
   - greycstoration.{c,h} renamed greycstorationplugin.{c,h}
   - plugin/greycstoration.h moved out of plugin folder, which is
     also removed.
   - added greycstoration.h to makefile.

Thanks,
Nicola

On 4/30/15 10:19 AM, Einar R√ľnkaru wrote:
> Hi.
>
> On 04/25/2015 06:41 PM, Nicola Ferralis wrote:
>> Updated patch based on Einar's feedback. Specifically:
>>
>>    - GreyCStorationWindow base class renamed PluginWindow
>>    - GreyCStorationConfig::interpolate is rewritten to actually
>>      interpolate
>>    - GreyCStorationConfig::interpolate variables changed to int64_t,
>>      not long
>>    - Replaced #include <libintl.h> with #include "language.h"
>>    - Removed commented c code
>>
>> The unlicensed files were released in the public domain with no interest
>> in its destiny from the original developer. I added headers to the
>> greycstoration.C and greycstoration.h to license it as GPL v2.
>
> Looks fine. Some problems exist.
>
> Why the name of the patch is changed? You may add the version like this
> [PATCH v2].
>
> The plugins/greycstoration.h is not included into make dist. The
> question is why one plugin must have 2 different files with the same
> name? IMHO the cinelerra plugin files can be renamed to for example
> greycstorationplugin.{C,h}, move the greycstoration.h file one level up
> and drop the plugin subdirectory.
>
> Thanks,
> Einar


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-GreyCStoration-plugin-to-Cinelerra-CV.patch.xz
Type: application/octet-stream
Size: 216476 bytes
Desc: not available
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20150502/69730036/attachment.obj>


More information about the Cinelerra mailing list