[CinCV TNG] [PATCH] Add GreyCStoration plugin to Cinelerra-CV

Nicola Ferralis feranick at hotmail.com
Thu Apr 30 16:23:31 CEST 2015


Thanks. The added "2" was to distinguish it (for me, really) from the 
previous version. Will remove it.

As for the name, that was a poor choice. The one inside plugin/ is from 
CIMG. I will change that as well.

Thanks, Einar.
Nicola

On 4/30/15 10:19 AM, Einar R√ľnkaru wrote:
> Hi.
>
> On 04/25/2015 06:41 PM, Nicola Ferralis wrote:
>> Updated patch based on Einar's feedback. Specifically:
>>
>>    - GreyCStorationWindow base class renamed PluginWindow
>>    - GreyCStorationConfig::interpolate is rewritten to actually
>>      interpolate
>>    - GreyCStorationConfig::interpolate variables changed to int64_t,
>>      not long
>>    - Replaced #include <libintl.h> with #include "language.h"
>>    - Removed commented c code
>>
>> The unlicensed files were released in the public domain with no interest
>> in its destiny from the original developer. I added headers to the
>> greycstoration.C and greycstoration.h to license it as GPL v2.
>
> Looks fine. Some problems exist.
>
> Why the name of the patch is changed? You may add the version like this
> [PATCH v2].
>
> The plugins/greycstoration.h is not included into make dist. The
> question is why one plugin must have 2 different files with the same
> name? IMHO the cinelerra plugin files can be renamed to for example
> greycstorationplugin.{C,h}, move the greycstoration.h file one level up
> and drop the plugin subdirectory.
>
> Thanks,
> Einar



More information about the Cinelerra mailing list