[CinCV TNG] [PATCH] Add GreyCStoration plugin to Cinelerra-CV

Nicola Ferralis feranick at hotmail.com
Sat Apr 25 17:41:15 CEST 2015


Updated patch based on Einar's feedback. Specifically:

   - GreyCStorationWindow base class renamed PluginWindow
   - GreyCStorationConfig::interpolate is rewritten to actually
     interpolate
   - GreyCStorationConfig::interpolate variables changed to int64_t,
     not long
   - Replaced #include <libintl.h> with #include "language.h"
   - Removed commented c code

The unlicensed files were released in the public domain with no interest 
in its destiny from the original developer. I added headers to the 
greycstoration.C and greycstoration.h to license it as GPL v2.

Thanks,
Nicola

On 4/22/15 2:57 PM, Einar Rünkaru wrote:
>
>
> On 04/22/2015 09:30 PM, Nicola Ferralis wrote:
>> Thanks, Einar. See below.
>>
>> On 4/22/15 1:14 PM, Einar Rünkaru wrote:
>>> Hi.
>>>
>>>
>>> Problems:
>>>
>>> - GreyCStorationWindow base class must be PluginWindow
>>> - GreyCStorationConfig::interpolate should interpolate values
>>> - GreyCStorationConfig::interpolate prototype id wrong: the type of
>>> *_frame named parameters must be int64_t
>>> greycstorationwindow.C - #include <libintl.h> blocck can be replaced
>>> with #include "language.h"
>>>
> Forgot to note: out commented c source should be removed.
>>
>> Will change that.
>>
>>> Most important: greycstoration.C, greycstoration.h,
>>> greycstorationwindow.C, greycstorationwindow.h have no licence. I am not
>>> a lawer, but as I understand it makes quite problematic to incorporate
>>> these into GPL-ed program.
>>>
>>
>> This is all GPL. I will add the related licensing to the files in
>> question.
>>
>
> How do you know?
>
> Einar


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-GreyCStoration-plugin-to-Cinelerra-CV-2.patch.xz
Type: application/octet-stream
Size: 216588 bytes
Desc: not available
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20150425/04d5d2ec/attachment.obj>


More information about the Cinelerra mailing list