[CinCV TNG] [PATCH] Rewrite of BC_DisplayInfo::test_window
j6t at kdbg.org
Fri Apr 24 22:56:51 CEST 2015
Am 23.04.2015 um 21:18 schrieb Einar Rünkaru:
> On 04/23/2015 09:36 PM, Johannes Sixt wrote:
>> Am 23.04.2015 um 19:46 schrieb Einar Rünkaru:
>>> The function test_window attempts to determine what direction and how
>>> much window manager moves window when drawing decorations around
>>> the window.
>>> This change simplifies the function: drawing only
>>> one window in some distance from screen borders, giving explictly
>>> some time to WM for finishing drawing and then detecting the maximum
>>> of coordinate change.
>>> The funcion gives name guicast_test to the created window.
>>> This makes possible to configure WM to treat the window
>>> specifically if needed.
>>> + if(xm < event.xconfigure.x)
>>> + xm = event.xconfigure.x;
>>> + if(ym < event.xconfigure.y)
>>> + ym = event.xconfigure.y;
>> I do not see where xm and ym are initialized before this use here.
>>> - }while(state != 3);
>>> + };
>> The semicolon is unnecessary.
> Thanks for review.
> Fixed patch attached.
I tested this new patch, and it does not work *at all*. I use the KDE
that comes with openSuSE 13.2. The window manager should therefore be KWM.
The old code works flawlessly. The windows are never offset by a single
With this patch, the windows are offset both horizontally and vertically
by dozens of pixels each time the program starts.
I did not erase my .bcast between the tests.
More information about the Cinelerra