[CinCV TNG] [PATCH] Rewrite of BC_DisplayInfo::test_window

Einar Rünkaru einarrunkaru at gmail.com
Thu Apr 23 21:18:12 CEST 2015


Hi.

On 04/23/2015 09:36 PM, Johannes Sixt wrote:
> Am 23.04.2015 um 19:46 schrieb Einar Rünkaru:
>> The function test_window attempts to determine what direction and how
>> much window manager moves window when drawing decorations around
>> the window.
>>
>> This change simplifies the function: drawing only
>> one window in some distance from screen borders, giving explictly
>> some time to WM for finishing drawing and then detecting the maximum
>> of coordinate change.
>>
>> The funcion gives name guicast_test to the created window.
>> This makes possible to configure WM to treat the window
>> specifically if needed.
>> ---

>> +            if(xm < event.xconfigure.x)
>> +                xm = event.xconfigure.x;
>> +            if(ym < event.xconfigure.y)
>> +                ym = event.xconfigure.y;
>
> I do not see where xm and ym are initialized before this use here.
>
>>           }
>> -     }while(state != 3);
>> +    };
>
> The semicolon is unnecessary.
>

Thanks for review.

Fixed patch attached.

Einar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Rewrite-of-BC_DisplayInfo-test_window.patch
Type: text/x-patch
Size: 5840 bytes
Desc: not available
URL: <http://lists.cinelerra-cv.org/pipermail/cinelerra/attachments/20150423/01ec287d/attachment.bin>


More information about the Cinelerra mailing list