[CinCV TNG] [PATCH] Fix missing return in handle_event in zoombar.C
feranick at hotmail.com
Sun Apr 12 22:20:09 CEST 2015
Patch dropped. It has been included in a more comprehensive patch where
return values are added when conversion to void is not possible.
> Date: Mon, 2 Mar 2015 15:34:54 -0500
> From: feranick at hotmail.com
> To: cinelerra at lists.cinelerra-cv.org
> Subject: Re: [CinCV TNG] [PATCH] Fix missing return in handle_event in zoombar.C
> On 3/2/15 3:00 PM, Johannes Sixt wrote:
> > Am 02.03.2015 um 20:43 schrieb Nicola Ferralis:
> >> Hi Hannes,
> >> Thanks. Early on I went on a file by file patch spree, which included
> >> most of the recent patches. However, I moved to a more inclusive patch
> >> (like the one I just submitted yesterday for the int to void), which
> >> captures (hopefully) most cases found by coverity. I plan to do the same
> >> going forward.
> > That patch I like! (And it looks reasonable from a cursory read.)
> Yes. BTW, I am adding even more to that patch, originally I was trying
> to keep the size of the patch from being too large. It currently only
> covers /cinelerra and guicast/ but based on this suggestion, I will
> include also files from /plugins.
> >> As for the clear_handle, that sort of slipped through. Since I have not
> >> pushed yet any of this individual patches, I'd be happy to repackage
> >> them by their fix strategy (i.e. adding returns, removing functions,
> >> changing to voids etc).
> > Great! But please complete your adventure before you push out any patchs.
> OK, sounds good.
> > Please do not submit an updated version of a large patch, such as your
> > earlier int-to-void patch, because sifting through what was already seen
> > and what is new would mean a lot of work for the reviewers. Feel free to
> > submit incremental patches for review, but at the end please collect
> > those with the same topic into a single patch.
> OK, will do.
> > Thanks,
> > -- Hannes
> >> Thanks,
> >> Nicola
> >> On 3/2/15 2:36 PM, Johannes Sixt wrote:
> >>> Am 02.03.2015 um 00:24 schrieb Nicola Ferralis:
> >>>> Throughout cinelerra, handle_event() return 1. Some calls miss
> >>>> the return, such as AutoTypeMenu::handle_event() in zoombar.C
> >>>> This patch adds return 1 to this call.
> >>> You seem to discover even more handle_event() implementations that need
> >>> treatment as you dig through coverity reports.
> >>> Would you kindly collect all of them into a single patch instead of
> >>> letting them trickle in one by one?
> >>> Concerning the other kinds of fixes (adding returns, removing entire
> >>> functions, etc.) let me point out that your work is very much
> >>> appreciated. But please finish your exploration, and then suggest a
> >>> reasonable separation of patches into a few topics. Having dozens of
> >>> "Coverity complained; here's a trivial fix" patches in the history is
> >>> not very helpful. Ideally, we should have just a handful of such patches
> >>> eventually. But it seems we are alread beyond this limit. Please don't
> >>> let the pile grow too much.
> >>> Thanks,
> >>> -- Hannes
> >>> _______________________________________________
> >>> Cinelerra mailing list
> >>> Cinelerra at lists.cinelerra-cv.org
> >>> http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra
> >> _______________________________________________
> >> Cinelerra mailing list
> >> Cinelerra at lists.cinelerra-cv.org
> >> http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra
> > _______________________________________________
> > Cinelerra mailing list
> > Cinelerra at lists.cinelerra-cv.org
> > http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Cinelerra