[CinCV TNG] [PATCH] close_all should consistently return 0, not 1.
feranick at hotmail.com
Wed Apr 8 19:01:52 CEST 2015
The issue of being slow needs to be seen as a trade-off with what it
provides to cinelerra. There are currently very limited ways to denoise
videos in cinelerra, and GCS can definitively add value.
Addressing the speed needs really getting into the actual CImg library
that is used as a backend for the plugin. That is a daunting task,
considering that the API for CImg has changed.
That is why I proposed people to test real cases to see if the value of
the plugin is sufficient to overlook the speed limitations. I am looking
into what is limiting the speed, but really I look forward to see what
people think from a user perspective.
On 4/8/15 12:28 PM, Einar Rünkaru wrote:
> On 04/08/2015 03:30 PM, Nicola Ferralis wrote:
>> Hi Einar,
>> Thanks. In addition to this patch, the only other recent one is "Fix
>> copy and paste error in cwindowgui.C". I am not aware of any other
>> outstanding one.
> For me in unclear state are:
> - Make result of division as floating without loosing precision (Mar,
> 18) - imho not important can be dropped
> - Removed unused update_duration_boxes() in recordgui.C (Feb 28)
> - Remove else condition that is never accessed in mwindowgui.C (Feb 28)
> - Removed unused update_derived() in transition.C (Mar 1)
> - Add returns to calls where missing. (Mar 3)
> - Fix missing return in handle_event in zoombar.C (Mar 2)
> - Add return to BC_Slider::activate() in bcslider.C (Mar 3)
>> I also submitted, not as an official patch just yet but only as a "
>> release candidate" of the GreyCstoration plugin for people to test. It
>> works very well on my tests, but given its complexity a little more user
>> testing would help before I submit it as an official patch.
> It was extremly slow when I tested - question is how slow can a plugin be.
>> I am still working on the motionblur plugin (to prevent it from
>> crashing). While I found where the problem is (see my previous note), I
>> cannot find why that is crushing cinelerra...
> Keep going.
> Cinelerra mailing list
> Cinelerra at lists.cinelerra-cv.org
More information about the Cinelerra