[CinCV TNG] [PATCH] close_all should consistently return 0, not 1.

Johannes Sixt j6t at kdbg.org
Tue Apr 7 22:25:55 CEST 2015


Am 07.04.2015 um 22:00 schrieb Nicola Ferralis:
> Hi, I was wondering if there are any comments on this patch.
>
> Thanks.
> Nicola
>
> On 3/31/15 4:52 PM, Nicola Ferralis wrote:
>> The non-zero return value of close_all in audioesound and audioalsa
>> is not consistent with similar calls in other audio*.C and video*.C
>> files. close_all is called upon by parent functions that then return
>> 0 themselves. If close_all returns non-zero, there may be issues
>> where the event is consumed within close_all. This patch sets the
>> returns to zero.
>>
>> This was a mistake I introduced in commit b7e5b1ae3a, based on wrong
>> consideration of the role of close_all as an event.

I don't see where the return value of close_all() is relevant. Where 
exactly is it inspected?

At this point, it would be much better to convert all incarnations of 
the function to void rather than fixing a small consistency error that 
has no consequence.

-- Hannes



More information about the Cinelerra mailing list