[CinCV TNG] [PATCH] Fix copy and paste error in cwindowgui.C

Nicola Ferralis feranick at hotmail.com
Sun Apr 5 22:05:02 CEST 2015


Rather than the merit of the patch, you seem to dislike the process that 
led to it. I am not really sure what's wrong with "While staring at the 
code, I noticed this duplicated message...". While this isn't what 
happened (you simply assumed it), I would have thought that patching a 
bug, even if trivial as an incorrect string, may be what matters.

Anyway, I get your point. So the patch is dropped. ;-)
Nicola

On 4/5/15 1:16 PM, Johannes Sixt wrote:
> Am 05.04.2015 um 13:46 schrieb Petter Reinholdtsen:
>> [Johannes Sixt]
>>> This is pointless. These strings are used only for debugging and have no
>>> influence on correctness. We certainly don't apply a patch that changes
>>> only this string.
>>
>> To me it seem like debugging become easier if the messages printed
>> during debugging are correct and not misleading.  Thus it seem like a
>> good idea to ensure the debug messages are as correct as possible.
>
> If this were justified with either
>
> - "I was debugging this and that and spent 10minutes at the wrong code
> until I noticed that the same message is printed from two different
> points..."
>
> or
>
> - "I have investigated each and every debugging message in the whole
> code base and found that this is the only case of a duplicated message..."
>
> I would have some sympathy for this change, but it looks more like
> "While staring at the code, I noticed this duplicated message...".
>
> -- Hannes
>
> _______________________________________________
> Cinelerra mailing list
> Cinelerra at lists.cinelerra-cv.org
> http://lists.cinelerra-cv.org/cgi-bin/mailman/listinfo/cinelerra




More information about the Cinelerra mailing list