[CinCV TNG] [PATCH] Updated C41 plugin - 2

Nicola Ferralis feranick at hotmail.com
Sun Jun 22 21:37:05 CEST 2014


Thanks, Petter. Will do.

Nicola

On 6/22/14, 3:32 PM, Petter Reinholdtsen wrote:
> [Nicola Ferralis]
>> I am resubmitting an improved patch for inclusion of the C41 plugin into
>> main git. This is an improved version over the one in the long dead
>> branch (it fixes compiler warnings, and a general cleanup). I could have
>> pushed it there, but think that is pointless given the state of that
>> branch.
> 
> Did you try to build it with -Wall too?  If not, please make sure it
> do not emit any warnings from its own source code when -Wall is used.
> I know some global headers cause warnings, but we will have to fix
> those later. :) I did not test to build with -Wall myself.
> 
> Will using it cause any valgrind issues when the source is built
> without optimizations (to avoid the strlen() ones)?  Did you check
> them out?
> 
>> If there are objections this time over its inclusion, please state them
>> clearly, since previous requests of clarifications fell into oblivion.
> 
> A few comments:
> 
>> diff -Nru cinelerra-cv.orig/configure.ac cinelerra-cv/configure.ac
>> --- cinelerra-cv.orig/configure.ac	2014-06-21 21:36:00.895132405 -0400
>> +++ cinelerra-cv/configure.ac	2014-06-21 21:36:07.255132338 -0400
>> @@ -648,6 +648,7 @@
>>  					plugins/bluebanana/Makefile \
>>  					plugins/brightness/Makefile \
>>  					plugins/burn/Makefile plugins/parametric/Makefile plugins/aging/Makefile \
>> +					plugins/C41/Makefile \
>>  					plugins/cdripper/Makefile \
>>  					plugins/chromakey/Makefile \
>>  					plugins/chromakeyhsv/Makefile \
> 
> I believe we should transform this list to use one entry per line and
> one tab in front of each item.  I suspect it is good to continue this
> with all new entries in the list, and clean up the rest later.
> 
>> diff -Nru cinelerra-cv.orig/plugins/C41/Makefile.am cinelerra-cv/plugins/C41/Makefile.am
>> --- cinelerra-cv.orig/plugins/C41/Makefile.am	1969-12-31 19:00:00.000000000 -0500
>> +++ cinelerra-cv/plugins/C41/Makefile.am	2014-06-21 21:36:07.259132338 -0400
>> @@ -0,0 +1,11 @@
>> +plugin_LTLIBRARIES = c41.la
>> +c41_la_LDFLAGS = -avoid-version -module -shared 
>> +c41_la_LIBADD = $(top_builddir)/plugins/colors/libcolors.la
>> +c41_la_SOURCES = c41.C 
>> +AM_CXXFLAGS = $(LARGEFILE_CFLAGS)
>> +
>> +AM_CPPFLAGS = -I$(top_srcdir)/guicast -I$(top_srcdir)/cinelerra -I$(top_srcdir)/quicktime -I$(top_srcdir)/plugins/colors
>> +LIBTOOL = $(SHELL) $(top_builddir)/libtool $(LTCXX_FLAGS)
>> +
>> +noinst_HEADERS = picon_png.h 
>> +EXTRA_DIST = picon.png
> 
> Please rewrite to generate picon_png.h from picon.png during build
> like the other plugins.
> 
> I have not looked at the source code, as I do not really know what the
> plugin is supposed to do. :)
> 
> The patch lacked a short and long description (aka the commit
> message).  Would be nice to have it in the next version, along
> information about its author and origin. :)
> 



More information about the Cinelerra mailing list